fix(scripting/lua): correct LuaNativeContext constructor #2286
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ehbw
force-pushed
the
fix/oal-arguments
branch
2 times, most recently
from
bdd8733 to
d68c321
Compare
thorium-cfx
suggested changes
Nov 27, 2023
| LUA_INLINE LuaNativeContext(void*, int numArguments) | ||
|
|
There was a problem hiding this comment.
Instead of renaming a fine parameter name, you can initialize them like this (preferred in C++):
LUA_INLINE LuaNativeContext(void*, int numArguments)
: numArguments(numArguments)
, numResults(0)
{
}
There was a problem hiding this comment.
That struct inherits fxNativeContext.
The amount of bloat/cruft in this area is quite high.
There was a problem hiding this comment.
Instead of renaming a fine parameter name, you can initialize them like this (preferred in C++):
LUA_INLINE LuaNativeContext(void*, int numArguments) : numArguments(numArguments) , numResults(0) { }
I originally did this, however it required me to redefine those fields again in the struct.
There was a problem hiding this comment.
🤦♂️I see... just do this->numArguments = numArguments for now then, we'll get to it later
Ehbw
force-pushed
the
fix/oal-arguments
branch
from
d68c321 to
33173c1
Compare
Ehbw
force-pushed
the
fix/oal-arguments
branch
from
33173c1 to
3f9b239
Compare
thorium-cfx
approved these changes
Nov 28, 2023
This was referenced Dec 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2183 and the forums post referenced (SetPlayerRoutingBucket, SetEntityRoutingBucket natives)
Repro